replace vsock helper server with socat and related changes #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4125 +/- ##
=======================================
Coverage 82.27% 82.27%
=======================================
Files 225 225
Lines 28470 28470
=======================================
Hits 23423 23423
Misses 5047 5047
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kalyazin
added
the
Status: Awaiting review
pb8o
previously approved these changes
Sep 22, 2023
This is to avoid code duplication. Signed-off-by: Nikita Kalyazin <[email protected]>
This is to reduce likelihood of bugs by reducing the amount of hand-written test code, in this case vsock echo server on the guest. See a similar change: commit bfa0dc7 Author: Pablo Barbáchano <[email protected]> Date: Wed Jun 7 22:04:38 2023 +0200 test: change the echo server in test_5_snapshots Signed-off-by: Nikita Kalyazin <[email protected]>
This is to avoid a situation where clients
do not get reply after they send a connect message,
like this:
framework/utils_vsock.py:197: in _vsock_connect_to_guest
ack_buf = sock.recv(32)
E Failed: Timeout >300.0s
Signed-off-by: Nikita Kalyazin <[email protected]>
In negative vsock tests, a guest echo server was started both independently and inside check_host_connections() leading to multiple instances running in the guest at the same time. This commit removes starting the server inside check_host_connections(). This makes it inconsistent with check_guest_connections() that still starts a host echo server internally, but removing it is not currenlty warrranted. Signed-off-by: Nikita Kalyazin <[email protected]>
Move the check that metrics contain an expected sigpipe count closer to the code that triggers the sigpipe signal. This will make it easier to diagnose potential issues related to check_host_connections() logic in the future. Signed-off-by: Nikita Kalyazin <[email protected]>
A large blob size (20M) is used in the first part of the test to increase likelihood of triggering the epipe condition. In the second part of the test, a call to check_host_connections() is performed to verify that Firecracker can still operate after receiving a sigpipe. There is no need to use a large blob size in the second part. This commit gets back to the default blob size in the second part of the test to reduce the test duration. Signed-off-by: Nikita Kalyazin <[email protected]>
Calculation of the path is usually done by the calling code anyway. Signed-off-by: Nikita Kalyazin <[email protected]>
pb8o
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
These changes are supposed to improve vsock tests' stability by:
socatinstead of hand-written vsock echo server in the guestReason
vsock-related tests are not stable.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] Any required documentation changes (code and docs) are included in this PR.[ ] API changes follow the Runbook for Firecracker API changes.[ ] User-facing changes are mentioned inCHANGELOG.md.[ ] All added/changed functionality is tested.[ ] NewTODOs link to an issue.rust-vmm.